[kwlug disc.] one degree of separation

Robert P. J. Day rpjday at crashcourse.ca
Thu Aug 7 09:07:27 EDT 2008


heh:

commit 685d87f7ccc649ab92b55e18e507a65d0e694eb9
Author: Linus Torvalds <torvalds at linux-foundation.org>
Date:   Wed Aug 6 19:24:47 2008 -0700

    Revert "pcm_native.c: remove unused label"

    This reverts commit 680db0136e0778a0d7e025af7572c6a8d82279e2.  The label
    is actually used, but hidden behind CONFIG_SND_DEBUG and the horrible
    snd_assert() macro.

    That macro could probably be improved to be along the lines of

        #define snd_assert(expr, args...) do { if ((void)(expr),0) { args; } } while (0)

    or similar to make sure that we always both evaluate 'expr' and parse
    'args', but while gcc should optimize it all away, I'm too lazy to
    really verify that.  So I'll just admit defeat and will continue to live
    with the annoying warning.

    Noted-by: Robert P. J. Day <rpjday at crashcourse.ca>
    Signed-off-by: Linus "Grr.." Torvalds

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================


More information about the KWLUG-Disc mailing list